Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: http buffer filter configuration (#6249) #6315

Closed
wants to merge 4 commits into from
Closed

feature: http buffer filter configuration (#6249) #6315

wants to merge 4 commits into from

Conversation

ruzmuh
Copy link

@ruzmuh ruzmuh commented Apr 4, 2024

Proposal for Issue #6249:
Introduce two optional command line flags, envoy-http-buffer-max-request-bytes and envoy-https-buffer-max-request-bytes, with default values set to 0. If the value is non-zero, an HTTP buffer filter will be added to the HTTP filter chain immediately after the DefaultFilters() with the max_request_bytes parameter. This configuration allows setting the buffer filter for the entire HTTP listener. In the future, it possible to provide ability to override these values on a per-route basis using bufferperroute.

@ruzmuh
feature: http buffer filter configuration (projectcontour#6249)
d3747f8 
Signed-off-by: Ruzil Mukhametov <ruzmuh@gmail.com>
@ruzmuh ruzmuh requested a review from a team as a code owner April 4, 2024 06:14
@ruzmuh ruzmuh requested review from skriss and sunjayBhatia and removed request for a team April 4, 2024 06:14
@sunjayBhatia sunjayBhatia requested review from a team, rajatvig and izturn and removed request for a team April 4, 2024 06:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Hi @ruzmuh! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

lubronzhan
lubronzhan reviewed Apr 7, 2024
View reviewed changes
cmd/contour/serve.go Outdated Show resolved Hide resolved
@lubronzhan lubronzhan added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Apr 7, 2024
@ruzmuh @lubronzhan
Apply suggestions from code review
69803ef 
Co-authored-by: Lubron <lubronzhan@gmail.com>
Signed-off-by: Ruzil Mukhametov <ruzmuh@gmail.com>
@ruzmuh
add release-note for the http buffer filter params
f952895 
Signed-off-by: Ruzil Mukhametov <ruzmuh@gmail.com>
sunjayBhatia
sunjayBhatia reviewed Apr 9, 2024
View reviewed changes
cmd/contour/serve.go Outdated Show resolved Hide resolved
@tsaarni tsaarni mentioned this pull request Apr 10, 2024
Closed
@ruzmuh
use config param instead of cli args
fba7631 
Signed-off-by: Ruzil Mukhametov <ruzmuh@gmail.com>
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2024
@tsaarni tsaarni removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.57%. Comparing base (c3d6cb4) to head (fba7631).
Report is 90 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6315   +/-   ##
=======================================
  Coverage   81.56%   81.57%           
=======================================
  Files         133      134    +1     
  Lines       15801    15828   +27     
=======================================
+ Hits        12888    12911   +23     
- Misses       2617     2621    +4     
  Partials      296      296
Files Coverage Δ
cmd/contour/servecontext.go 86.02% <100.00%> (+0.07%) ⬆️
internal/contourconfig/contourconfiguration.go 98.70% <100.00%> (+0.01%) ⬆️
internal/envoy/v3/buffer.go 100.00% <100.00%> (ø)
internal/xdscache/v3/listener.go 92.06% <100.00%> (+0.05%) ⬆️
pkg/config/parameters.go 88.07% <100.00%> (+0.04%) ⬆️
cmd/contour/serve.go 22.59% <0.00%> (-0.07%) ⬇️

... and 5 files with indirect coverage changes

@sunjayBhatia sunjayBhatia self-requested a review May 10, 2024 15:54
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this Jul 1, 2024
@frankh
Copy link

frankh commented Aug 20, 2024

can this be reopened? It's a pretty important feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubronzhan lubronzhan lubronzhan left review comments

@skriss skriss Awaiting requested review from skriss skriss is a code owner automatically assigned from projectcontour/maintainers

@rajatvig rajatvig Awaiting requested review from rajatvig rajatvig was automatically assigned from projectcontour/contour-reviewers

@izturn izturn Awaiting requested review from izturn izturn was automatically assigned from projectcontour/contour-reviewers

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia

Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note/minor A minor change that needs about a paragraph of explanation in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ruzmuh @frankh @sunjayBhatia @lubronzhan @tsaarni